[CUB] Refactor DevicePartition::If to always take an environment#9464
Open
miscco wants to merge 1 commit into
Open
[CUB] Refactor DevicePartition::If to always take an environment#9464miscco wants to merge 1 commit into
DevicePartition::If to always take an environment#9464miscco wants to merge 1 commit into
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
miscco
force-pushed
the
device_partition_flagged_env
branch
from
89ae2b2 to
b6d1633
Compare
miscco
force-pushed
the
device_partition_flagged
branch
2 times, most recently
from
04194e2 to
558503f
Compare
miscco
force-pushed
the
device_partition_flagged_env
branch
2 times, most recently
from
48a510a to
bd7b7d9
Compare
miscco
force-pushed
the
device_partition_flagged
branch
from
003860d to
214516b
Compare
miscco
force-pushed
the
device_partition_flagged_env
branch
from
bd7b7d9 to
1fd1bb1
Compare
Contributor
miscco
force-pushed
the
device_partition_flagged
branch
from
214516b to
ef6e110
Compare
miscco
force-pushed
the
device_partition_flagged_env
branch
from
1fd1bb1 to
459699b
Compare
miscco
force-pushed
the
device_partition_flagged
branch
from
ef6e110 to
5fc7e96
Compare
miscco
force-pushed
the
device_partition_flagged_env
branch
from
459699b to
4e582bc
Compare
This comment has been minimized.
This comment has been minimized.
miscco
force-pushed
the
device_partition_flagged_env
branch
from
4e582bc to
1abbfcf
Compare
miscco
force-pushed
the
device_partition_flagged
branch
from
5fc7e96 to
7252c69
Compare
miscco
force-pushed
the
device_partition_flagged_env
branch
from
1abbfcf to
d1954a8
Compare
miscco
force-pushed
the
device_partition_flagged
branch
from
7252c69 to
45c5b58
Compare
Jacobfaib
approved these changes
Jun 23, 2026
|
|
||
| // Copy the result back from storage | ||
| _CCCL_TRY_CUDA_API( | ||
| ::cudaMemcpyAsync, |
Contributor
There was a problem hiding this comment.
Unrelated to the current PR, but we should try and use the driver wherever possible so that we are explicit about the CUDA contexts. Especially for multi-GPU, the fact that runtime API leaves its the context on the stack is very problematic because some APIs (like cuMemcpy() actually) will behave differently if there is a context on the stack already.
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
approved these changes
Jun 23, 2026
miscco
force-pushed
the
device_partition_flagged
branch
from
45c5b58 to
e2fea4c
Compare
miscco
force-pushed
the
device_partition_flagged_env
branch
from
d1954a8 to
901cf2f
Compare
miscco
force-pushed
the
device_partition_flagged
branch
from
e2fea4c to
a910255
Compare
miscco
force-pushed
the
device_partition_flagged_env
branch
from
901cf2f to
58ecf4a
Compare
This comment has been minimized.
This comment has been minimized.
miscco
force-pushed
the
device_partition_flagged
branch
from
a910255 to
eedc632
Compare
miscco
force-pushed
the
device_partition_flagged_env
branch
2 times, most recently
from
885dd2d to
f802c13
Compare
miscco
force-pushed
the
device_partition_flagged
branch
from
eedc632 to
2b07d4f
Compare
miscco
force-pushed
the
device_partition_flagged_env
branch
from
f802c13 to
7edce6b
Compare
miscco
force-pushed
the
device_partition_flagged
branch
from
2b07d4f to
9417767
Compare
This comment has been minimized.
This comment has been minimized.
miscco
force-pushed
the
device_partition_flagged
branch
from
9417767 to
c94525f
Compare
miscco
force-pushed
the
device_partition_flagged_env
branch
2 times, most recently
from
5425b25 to
d03bf64
Compare
miscco
force-pushed
the
device_partition_flagged
branch
from
c94525f to
01959c0
Compare
We want to be able to pass tunings to the APIs that take user provided memory Make sure we can pass any environment or stream type to them
miscco
force-pushed
the
device_partition_flagged
branch
from
01959c0 to
9e01dd2
Compare
miscco
force-pushed
the
device_partition_flagged_env
branch
from
d03bf64 to
614dd6d
Compare
Contributor
😬 CI Workflow Results🟥 Finished in 2h 49m: Pass: 97%/345 | Total: 14d 11h | Max: 2h 47m | Hits: 38%/1705248See results here. |
bernhardmgruber
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes
Checklist