[CUB] Refactor DeviceHistogram::HistogramRange to always take an environment#9555
Open
miscco wants to merge 1 commit into
Open
[CUB] Refactor DeviceHistogram::HistogramRange to always take an environment#9555miscco wants to merge 1 commit into
DeviceHistogram::HistogramRange to always take an environment#9555miscco wants to merge 1 commit into
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
miscco
force-pushed
the
device_histogram_multi_range_env
branch
from
9b27b34 to
c37d67d
Compare
miscco
force-pushed
the
device_histogram_range_env
branch
from
a22c7b9 to
ca52969
Compare
…vironment We want to be able to pass tunings to the APIs that take user provided memory.
miscco
force-pushed
the
device_histogram_range_env
branch
from
ca52969 to
e67552a
Compare
miscco
force-pushed
the
device_histogram_multi_range_env
branch
from
c37d67d to
ada45f2
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 06m: Pass: 100%/287 | Total: 2d 12h | Max: 1h 06m | Hits: 89%/223008See results here. |
| REQUIRE(d_histogram == expected); | ||
| } | ||
|
|
||
| TEST_CASE("DeviceHistogram::HistogramRange works with user provided memory and environment", "[histogram][device]") |
Contributor
There was a problem hiding this comment.
Important: guard the new test by #if TEST_LAUNCH == 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes
Checklist