Add cuda::ceil_ilog10#9613
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
Added What changed
Notes
Walkthroughimportant: Adds Changesceil_ilog10 API updates
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 284ef720-5bac-4fd3-8ad9-8b2137beaa96
📒 Files selected for processing (4)
docs/libcudacxx/extended_api/math.rstdocs/libcudacxx/extended_api/math/ilog.rstlibcudacxx/include/cuda/__cmath/ilog.hlibcudacxx/test/libcudacxx/cuda/cmath/ilog.pass.cpp
This comment has been minimized.
This comment has been minimized.
🥳 CI Workflow Results🟩 Finished in 1h 21m: Pass: 100%/120 | Total: 2d 15h | Max: 1h 19m | Hits: 82%/439967See results here. |
Description
The
ceil_ilog10can be used to covert integers to chars (e.g.to_chars).In addition, we already have
ilog2,ceil_ilog2, andilog10, so would make sense to addceil_log10for completeness.It tried a couple of optimizations but the simplest version should be also the most efficient.