[libcu++] Add tests for cross device APIs and APIs related to a device with a different device set current#9617
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (10)
🚧 Files skipped from review as they are similar to previous changes (10)
Expanded multi-GPU test coverage across libcu++/CCCLRT to verify device/stream-bound APIs continue to operate correctly when the current CUDA device/context differs from the device used by the API call.
WalkthroughAdds current-context guards for internal buffer copies and expands multi-GPU tests so explicit-device streams, launches, events, memory, and buffer construction are exercised when current and explicit devices differ. ChangesCurrent-context and explicit-device behavior
Possibly related PRs
Suggested reviewers
Comment |
This comment has been minimized.
This comment has been minimized.
c35e017 to
3453af6
Compare
😬 CI Workflow Results🟥 Finished in 1h 18m: Pass: 99%/120 | Total: 1d 14h | Max: 1h 02m | Hits: 99%/353935See results here. |
We test our APIs with empty driver context stack, but it seems sometimes that differs from it being set to a non-matching device. This PR adds a bunch of tests to APIs that take a device or a stream to confirm that if a different device is set current they continue to work.
It also adds tests for using events/streams across devices.