[libcu++][cuda::ptx] Add prefetch PTX wrappers#9620
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdds prefetch PTX wrapper
Assessment against linked issues
Out-of-scope changesNo out-of-scope changes found. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
libcudacxx/include/cuda/__ptx/instructions/prefetch.h (1)
12-13: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winsuggestion: Rename the include guard to the path-derived form used in libcudacxx headers.
_CUDA_PTX_PREFETCH_H_is too generic forcuda/__ptx/instructions/prefetch.hand risks collisions with future headers. As per coding guidelines, "Headers must use include guards derived from the uppercase full path."Also applies to: 40-40
Source: Coding guidelines
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3f919381-8399-4ebf-9476-f350f32fafdc
⛔ Files ignored due to path filters (2)
libcudacxx/include/cuda/__ptx/instructions/generated/prefetch.his excluded by!**/generated/**libcudacxx/test/libcudacxx/cuda/ptx/generated/prefetch.his excluded by!**/generated/**
📒 Files selected for processing (3)
libcudacxx/include/cuda/__ptx/instructions/prefetch.hlibcudacxx/include/cuda/ptxlibcudacxx/test/libcudacxx/cuda/ptx/ptx.prefetch.compile.pass.cpp
😬 CI Workflow Results🟥 Finished in 1h 11m: Pass: 99%/120 | Total: 2d 04h | Max: 1h 03m | Hits: 78%/484549See results here. |
Second try to fix #9616
I took Fede's advice and tried to use the internal libcucxx_ptx tool and then added a test. Given that both Bernhard and Fede are out I'll ask @ahendriksen to pinpoint any wrongdoings he might notice.