Add cuTENSOR safe wrapper#570
Open
g-ampo wants to merge 2 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a safe abstraction layer for cuTENSOR, providing RAII wrappers for handles, descriptors, and execution plans, along with high-level methods for tensor contraction and reduction. It also enhances the low-level result module with dynamic library loading for compute descriptors. Review feedback identifies a misleading error message during library loading and recommends avoiding .unwrap() in Drop implementations to prevent potential process aborts during panics.
g-ampo
changed the title
Owner
|
Hey I'm gonna be honest, this PR is way too big for me to review and needs to be split into multiple sub PRs. I appreciate the use of agents, but this is not set up nicely for me. Did you run the tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cuTENSOR safe wrapper
Closes #392.
CuTensorhandle withcontract()andreduce()managing the full pipeline (descriptors -> operation -> plan -> workspace -> execute -> cleanup). RAII wrappers for all intermediate objects.create_compute_descriptor/destroy_compute_descriptorvia dynamic loading. cuTENSOR 2.2.0 segfaults on the predefined sentinel values that older versions accepted.