feat(gerrit): enable push signing when gitPrivateKey is set#44228
Open
felipecrs wants to merge 3 commits into
Open
feat(gerrit): enable push signing when gitPrivateKey is set#44228felipecrs wants to merge 3 commits into
gitPrivateKey is set#44228felipecrs wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Amongst the platforms supported by Renovate, Gerrit is the only one that supports git push signing.
In fact, Gerrit does not support commit signing. It only supports push signing. It is harmless to sign Gerrit commits though, as Gerrit won't reject them. It's still useful in case some additional repository browser is used, like GerritHub which replicates the commits back to GitHub.
This PR enables push signing for Gerrit whenever
gitPrivateKeyis set. Push signing is enabled asif-asked, which means that git will only sign the push if the remote signals support for it.I decided not to add a new config option because no one else beside Gerrit users would be able to use it anyway, and also we already have too many config options.
Because of
if-asked, it would have been safe to enable it for all platforms, but I decided not to do it because thegit pushcommand issues a warning when the remote does not support it. That would be confusing for users of other platforms.The implementation is done so that it can be easily extended to other platforms in the future, if the other platforms ever add support for it.
Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Claude Opus 4.6 was used to generate the initial changes.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
Gerrit Hub does not have push signing enabled. This was tested on an internal Gerrit instance.