Skip to content

Rename HAS_CT_PROJECTION to HAS_CONST_ALIAS#158495

Open
Shourya742 wants to merge 1 commit into
rust-lang:mainfrom
Shourya742:2026-06-27-rename-tflag
Open

Rename HAS_CT_PROJECTION to HAS_CONST_ALIAS#158495
Shourya742 wants to merge 1 commit into
rust-lang:mainfrom
Shourya742:2026-06-27-rename-tflag

Conversation

@Shourya742

Copy link
Copy Markdown
Member

follow up: #158115 (comment)

r? @BoxyUwU

@rustbot

rustbot commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in abstract_const.rs

cc @BoxyUwU

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 27, 2026
@rustbot

rustbot commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

@Shourya742

Copy link
Copy Markdown
Member Author

cc: @khyperia

@khyperia khyperia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

One bikeshed nit: most (but annoyingly, not all) flags here are singular, not plural (and all uses of the word "alias" are singular). So maybe HAS_CONST_ALIAS. But, shrug.

View changes since this review

@rust-cloud-vms rust-cloud-vms Bot force-pushed the 2026-06-27-rename-tflag branch from 07cf573 to e3e20ed Compare June 29, 2026 07:43
@Shourya742

Copy link
Copy Markdown
Member Author

Thanks!

One bikeshed nit: most (but annoyingly, not all) flags here are singular, not plural (and all uses of the word "alias" are singular). So maybe HAS_CONST_ALIAS. But, shrug.

View changes since this review

Changed to singular form here: e3e20ed, thanks

@Shourya742 Shourya742 changed the title Rename HAS_CT_PROJECTION to HAS_CONST_ALIASES Rename HAS_CT_PROJECTION to HAS_CONST_ALIAS Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants